pre
public synchronized List<AccountWrapper> queryAccountViaTag(String tag, Boolean isLock) {
List<AccountWrapper> acc = new ArrayList<>();
if (tag.contains("&") && !tag.contains("_sc") && !tag.contains("_dc") && !tag.contains("_conference")) {
String[] separateTag = tag.split("&");
for (String getTag : separateTag) {
acc.addAll(queryAccountFromDB(getTag, 1, "RM", isLock));
}
} else if (tag.contains("&") && (tag.contains("_sc") || tag.contains("_dc") || tag.contains("_conference"))) {
String[] separateTag = tag.split("&");
List<String> tagList = Arrays.asList(separateTag);
Set<String> uniqueSet = new HashSet<>(tagList);
Map<String, Integer> map = new HashMap<String, Integer>();
for (String temp : uniqueSet) {
Integer count = Collections.frequency(tagList, temp);
map.put(temp, count);
}
for (Map.Entry<String, Integer> entry : map.entrySet()) {
logger.info("Key = " + entry.getKey() + ", Value = " + entry.getValue());
String getTag;
if(entry.getKey().endsWith("_sc")) {
getTag = entry.getKey().replace("_sc", "");
acc.addAll(queryAccountFromDB(getTag, entry.getValue(), "SC", isLock));
} else if (entry.getKey().endsWith("_dc")) {
getTag = entry.getKey().replace("_dc", "");
acc.addAll(queryAccountFromDB(getTag, entry.getValue(), "DC", isLock));
} else if (entry.getKey().endsWith("_conference")) {
getTag = entry.getKey().replace("_conference","");
acc.addAll(queryAccountFromDB(getTag, entry.getValue(),"CF", isLock));
}
else {
getTag = entry.getKey();
acc.addAll(queryAccountFromDB(getTag, 1, "RM",isLock));
}
}
} else {
if(tag.endsWith("_sc")) {
tag = tag.replace("_sc", "");
}
if(tag.endsWith("_dc")) {
tag = tag.replace("_dc", "");
}
if(tag.endsWith("_conference")) {
tag = tag.replace("_conference","");
acc = queryAccountFromDB(tag, 1, "CF", isLock);
} else {
acc = queryAccountFromDB(tag, 1, "RM", isLock);
}
}
return acc;
}
之前的版本烘浦,一個(gè)方法里非常非常非常的冗長(zhǎng)疚脐,如果有什么新的需求的話,又要再繼續(xù)if...else...县昂,這是很可怕的事情
把需求重新捋一遍肮柜,重新把它們拆開,雖然看著改版后的代碼好像更長(zhǎng)了倒彰,但是如果有新需求的話审洞,只要在map里加一條記錄即可
after
# 不同的類型的賬號(hào)需求
public static Map<String, String> tagTailMapping =new HashMap<String, String>(){{
put("_dc", "DC");
put("_sc", "SC");
put("_conference", "CF");
}};
# 主體方法
public synchronized List<AccountWrapper> queryAccountViaTag(String tag, Boolean isLock) {
List<AccountWrapper> acc = new ArrayList<>();
Map<String, Integer> map = new HashMap<>();
# 根據(jù)提供的tag串,是否有包含&待讳。再根據(jù)優(yōu)先返回原則芒澜,最容易判斷的條件優(yōu)先返回,可以提高代碼運(yùn)行效率
if (!tag.contains("&")) {
acc = queryTailTagAccounts(tag, 1, isLock);
return acc;
}
if (tag.contains("&")) {
String[] separateTag = tag.split("&");
List<String> tagList = Arrays.asList(separateTag);
map = convertListToUniqueMap(tagList);
}
for (Map.Entry<String, Integer> entry : map.entrySet()) {
logger.info("Key = " + entry.getKey() + ", Value = " + entry.getValue());
acc.addAll(queryTailTagAccounts(entry.getKey(), entry.getValue(), isLock));
}
return acc;
}
# 需求是根據(jù)不同賬號(hào)提供的tag最后一個(gè)_xx來決定需要運(yùn)行什么方法
private List<AccountWrapper> queryTailTagAccounts(String tag, int num, Boolean isLock) {
List<AccountWrapper> acc = new ArrayList<>();
String getTag;
String tailTag = tag.contains("_") ? tag.substring(tag.lastIndexOf("_")) : ""; #獲取最后一個(gè) _xx创淡,再把對(duì)應(yīng)的type傳進(jìn)去
if (tagTailMapping.containsKey(tailTag)) {
getTag = tag.replace(tailTag, "");
acc.addAll(queryAccountFromDB(getTag, num, tagTailMapping.get(tailTag), isLock));
}
else {
for (int i = 0; i < num; i++) {
acc.addAll(queryAccountFromDB(tag, 1, "RM", isLock));
}
}
return acc;
}
# 把tag串解析出來的list進(jìn)行處理撰糠,減少運(yùn)行時(shí)間
private Map<String, Integer> convertListToUniqueMap(List<String> tagList) {
Set<String> uniqueSet = new HashSet<>(tagList);
Map<String, Integer> map = new HashMap();
for (String temp : uniqueSet) {
Integer count = Collections.frequency(tagList, temp);
String tailTag = temp.contains("_") ? temp.substring(temp.lastIndexOf("_")) : "";
if (count == 1 && tagTailMapping.containsKey(tailTag)){
temp = temp.replace(tailTag, "");
putMapping(map, temp, count);
} else {
putMapping(map, temp, count);
}
}
return map;
}
private void putMapping(Map<String, Integer> map, String temp, Integer count) {
if (map.containsKey(temp)) {
map.put(temp, map.get(temp) + count);
} else {
map.put(temp, count);
}
}